github-clean-feed icon indicating copy to clipboard operation
github-clean-feed copied to clipboard

Move to templating

Open fregante opened this issue 8 years ago • 2 comments

@gloooom: And I think maybe it's worth to rewrite all the mechanics of the github news page and make them in a completely different form with sorting, global groups, tracking only certain events of a particular person or repository. And generally abandon the standard GitHub's render. https://github.com/bfred-it/github-clean-feed/pull/5#discussion_r120180521

The idea behind reusing GitHub's own elements instead of using a simple templates was to try to keep it working even if GitHub makes some changes to the elements. That may be slightly true, but this extension is still very dependent on the structure of the GitHub's DOM.

So, yeah, it would be nice to just parse the data and feed it to a template, or even better, Svelte — the problem is that it would require a complete rewrite of the extension and I'm not sure I'd want to write that.

If you're thinking about doing that, keep in mind that it'll probably need a lot of discussion beforehand and a few review cycles afterwards.

sorting, global groups,

I had thought about grouping by date rather than by page, that would be great with Svelte.

tracking only certain events of a particular person or repository

You can just visit the user's profile for that: https://github.com/bfred-it

fregante avatar Jun 07 '17 11:06 fregante

If I have free time, I'll try to start. It will take a lot of time for developing. Especially since I first encounter Svelte. And of course I'll start the discussion before writing the code.

You can just visit the user's profile for that: https://github.com/bfred-it

But if I has 10-15 profiles, for which I follows, it is not very convenient for me to go to everyone.

pyatyispyatil avatar Jun 12 '17 13:06 pyatyispyatil

But if I has 10-15 profiles, for which I follows, it is not very convenient for me to go to everyone.

If you want to see them all at once, you're following them. Perhaps it's easier to think of this feature as "Hide something" instead. What do you want to hide? If it's not them it's you, if I understand correctly. So maybe we can add a filter for "Hide my own events." Would that work?

fregante avatar Jun 12 '17 13:06 fregante