Some tweaks

[Riajyuu]

• [ ] restore all favicons
• [ ] groups also releases, tags, commits, etc. aka everthing
• groups by authors

[fregante]

1. Are you talking about these?
2. It makes sense 👍
3. Too complex

[Riajyuu]

Are you talking about these?

Exactly.

As far as authors, maybe I should correct a little bit: from the same repos

[fregante]

As far as authors, maybe I should correct a little bit: from the same repos

I'm not sure I understand, can you make an example?

[Riajyuu]

See this case:

Group news from ScreenToGif together Another group are news from you-get

[fregante]

They are grouped like this now right?

• soimort/you-get
  • #2054 rosynirvana commented
  • #2047 rosynirvana commented
• NickeManarin/ScreenToGif
  • #100 closed issue
  • #100 commented

How should they be grouped?

[Riajyuu]

Yes, exactly. Another plausible situation:

• soimort/you-get
  • #2054 rosynirvana commented
  • #2047 rosynirvana commented
  • [owner] created tags ?????
• NickeManarin/ScreenToGif
  • #100 closed issue
  • #100 commented
  • [owner] pushed master ????

[fregante]

That's suggestion 2, but what is suggestion 3? ("groups by authors")

[Riajyuu]

They are a little bit different: Authors simple means the same User. Aka, list activities from the same user at different places together. e.g. : rosynirvana :

• commented at you-get issue ???
• open pull request at ScreenToGif ???
• create repo ????

[fregante]

Yeah that's too complex because things are already grouped by repo, they can't be grouped by both things.

[Riajyuu]

they can't be grouped by both things.

What about this: when this feature is enabled, only group things as users.

The benefit is that you can track users you followed in a more staightforward way.

[fregante]

The issue is that to do it I'd have to almost rewrite everything. You can group them by user with a simple change, but then each event is missing the repo name:

diff --git a/src/content.js b/src/content.js
index 6cac979..8f14d64 100644
--- a/src/content.js
+++ b/src/content.js
@@ -43,10 +43,10 @@ function groupByRepo(events) {
 			relatedEl,
 			timeEl: originalEvent.querySelector('.time'),
 		};
-		if (!repos.has(repo)) {
-			repos.set(repo, new Set());
+		if (!repos.has(actorEl.textContent)) {
+			repos.set(actorEl.textContent, new Set());
 		}
-		repos.get(repo).add(event);
+		repos.get(actorEl.textContent).add(event);
 		originalEvent.remove();
 		return repos;
 	}, new Map());

This is too much work and it's not useful to me.

[Riajyuu]

Got it. Thanks for patience.