dmd-extensions icon indicating copy to clipboard operation
dmd-extensions copied to clipboard

Published 20 hours ago • verified publisher icon freezy

Close serial connection for ZeDMD on Dispose(),

Open mkalkbrenner opened this issue 9 months ago • 3 comments

closes https://github.com/freezy/dmd-extensions/issues/474

mkalkbrenner avatar May 11 '24 11:05 mkalkbrenner

#477 fixes the multi disposal. You should open the connection on Init() and close it on Dispose(). Does that make this PR obsolete?

freezy avatar May 18 '24 21:05 freezy

#477 fixes the multi disposal. You should open the connection on Init() and close it on Dispose(). Does that make this PR obsolete?

No, at the moment we don't close the connection on Dispose(). So the PR should be required.

The downside is that you can't open multiple subsequent tables in VPX anymore but need to close VPX after each table.

mkalkbrenner avatar May 21 '24 18:05 mkalkbrenner

The downside is that you can't open multiple subsequent tables in VPX anymore but need to close VPX after each table.

What's the upside, then? ;)

freezy avatar May 21 '24 18:05 freezy

If you use a frontend that uses dmdext to show something on the DMD, the connection needs to be closed before VPX gets started. That's how the other DMDs behave as well.

mkalkbrenner avatar May 24 '24 09:05 mkalkbrenner