dmd-extensions icon indicating copy to clipboard operation
dmd-extensions copied to clipboard

Big borders around alphanumerics

Open tommkell opened this issue 2 years ago • 12 comments

When using the punch feature of b2s, the alphanumeric displays punch out a bigger area than needed. The only way around this is to make the alphanumerics much smaller + doesn't look great. Would it be possible to reduce the size of the borders around them? Thank you

tommkell avatar Jan 02 '24 18:01 tommkell

I've done so in my branch of Freezy's repository. I think the best would be to allow the properties LinePaddingPercentage and OuterPaddingPercentage to be set in the configuration editor. With my meager skills :) I will work on this and perhaps propose a merge at some later date. For now, you are welcome to pull my source for RasterizeDimensions.cs and recompile.

buffdriver avatar Jan 02 '24 22:01 buffdriver

@buffdriver I've no idea how to do that! Can you explain it?

tommkell avatar Jan 03 '24 14:01 tommkell

Sorry, it was a bit presumptuous of me to have you recompile the source. Go [here] and download the zip file. Unzip and save the three binaries in the appropriate folder. Be sure to backup first.

buffdriver avatar Jan 03 '24 17:01 buffdriver

Thanks for this @buffdriver, you're a legend 🙂

tommkell avatar Jan 03 '24 20:01 tommkell

@buffdriver Interested in getting this back upstream? :)

freezy avatar Apr 21 '24 14:04 freezy

@freezy I wish I could say I've done something other than change the hard-coded values for padding. It's all of about two lines of code. If you feel the new values are better, I would be happy to push. It has remained useful to me.

buffdriver avatar Apr 21 '24 15:04 buffdriver

Maybe make it configurable? That would be the best option.

freezy avatar Apr 22 '24 19:04 freezy

I am working on it now, will keep you posted on progress.

Cheers!

On Apr 22, 2024, at 2:12 PM, freezy @.***> wrote:

Maybe make it configurable? That would be the best option.

— Reply to this email directly, view it on GitHub https://github.com/freezy/dmd-extensions/issues/456#issuecomment-2070707174, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYDYRCOP5MKX7OYJQYQR5TY6VOJJAVCNFSM6AAAAABBKMAVFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZQG4YDOMJXGQ. You are receiving this because you were mentioned.

buffdriver avatar Apr 22 '24 19:04 buffdriver

I would really appreciate the configurability. I'd also suggest, like the original comment, that the default border/padding around the alphanumerics becomes a lot smaller as the size of the visible part of the display is almost universal across machines. The current amount of padding is way too big.

SmedleyB avatar Apr 24 '24 14:04 SmedleyB

I’m working on making it configurable, but my programming skills are meager. My branch hard coded it to 4% padding vs the default 20%.

On Apr 24, 2024, at 9:35 AM, SmedleyB @.***> wrote:

I would really appreciate the configurability. I'd also suggest, like the original comment, that the default border/padding around the alphanumerics becomes a lot smaller as the size of the visible part of the display is almost universal across machines. The current amount of padding is way too big.

— Reply to this email directly, view it on GitHub https://github.com/freezy/dmd-extensions/issues/456#issuecomment-2075101785, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYDYRF6RKZLYRMRQLTYT4LY667LLAVCNFSM6AAAAABBKMAVFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZVGEYDCNZYGU. You are receiving this because you were mentioned.

buffdriver avatar Apr 24 '24 14:04 buffdriver

Hi Freeze,

I have completed the initial work on the capability to specify and edit the line and outer padding for alphanumeric displays. Would you care to test the DMDDevice64.dll before I try to commit to your main branch?

On Apr 21, 2024, at 9:32 AM, freezy @.***> wrote:

@buffdriver https://github.com/buffdriver Interested in getting this back upstream? :)

— Reply to this email directly, view it on GitHub https://github.com/freezy/dmd-extensions/issues/456#issuecomment-2068066009, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYDYREIKNR3GVKFCUVHPZDY6PEYRAVCNFSM6AAAAABBKMAVFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGA3DMMBQHE. You are receiving this because you were mentioned.

buffdriver avatar Apr 26 '24 23:04 buffdriver