freezy
NetCore3.1 port
This is an early commit, not ready for merge.
Everything build fine and DMDExt tests are fine, but:
- DMDDevice fails from VPinMame (it runs ok through direct dll access).
- Installer is untested.
Tested, and seems to run fine both on command line and through VPM?
I'm wondering about the packing though. Currently as you noticed we're using Fody/Costura to pack the dependencies into a single file - How does that work with dotnet core? Last time I tested the built-in feature, it packed the entire framework into it, resulting in a 70mb+ file size. Here it only increased a little (~2-3mb).
For VPM, it is not working here. I have upgraded PinMameTest to perform some more test (access by project reference / DLL loading / through COM) but did not have time to go further.
For the packing, there are 2 things;
- For the DLL (LibDMD / DMDDevice), Fody/Costura do the job like before,
- For the EXE, I use the new publishing feature included in .NET Core (see https://github.com/freezy/dmd-extensions/pull/299/files#diff-3fd9ff6647e2ac8ec3008bb0621c0b411a0ac354f741e4bbb43ea76558a38b35 and https://github.com/freezy/dmd-extensions/pull/299/files#diff-efc75026adc9d1d95c2fbfa0265d3f11bde3d3c2e5b4a21bc2a6429fea3c9e91). There are quite a few options when publishing (hence the commented out variants in these files). Here, I went single file but not self-contained so the .NET Core framework is not included. For more info see https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-publish .
The installer has not yet been updated to trigger the publish command and use its output. So this is pending too. For the time being, you can test by right clicking on DMDExt in VS and select 'Publish' with one of the provided profiles.
Hey @vbousquet is this ready to test and merge? Looks like AppVeyor shortened the life time of their artifacts to one month only so people started sharing betas though Dropbox and whatnot.
So a new version soon would be good. You think this is already mature enough?
I have very little free time at the moment, so I was not able to work again on it. I don't think it is ready for merging for the point I identified previously:
- dmdevice.dll seems to not be packaged correctly (I had situation where it would fail with a FileIO issue, I guess linked to the failure of loading unpacked dll),
- the installer has to be adapted to the new publish process.
Sadly, I don't think I will have time to work on it in the coming weeks so I think this should wait a bit more (unless you want to tackle with it). I don't think this is really a problem; a release with all the already merged improvments would be good anyway. This one is mainly to prepare for future improvments and eventually porting for VPE.
Alright, no worries, just wasn't sure whether an action from my side was needed. I might push out a release before this goes in then. Cheers!
Hey, any update? We'll be dropping a new version soon, having this finalized would be awesome. Thanks!