android-seed icon indicating copy to clipboard operation
android-seed copied to clipboard
verified publisher icon freezy

Update to android gradle plugin 1.5.0

Open joebowbeer opened this issue 9 years ago • 3 comments

Android gradle plugin and tools and dependencies updated. Add .idea to .gitignore.

joebowbeer avatar Feb 10 '16 00:02 joebowbeer

Thanks! But the .idea folder is actually useful, apart from workspace.xml and the libraries sub folder. Could you put them back in? Then I'll merge.

freezy avatar Feb 10 '16 08:02 freezy

My intent was not to delete the IntelliJ files, but to remove them from source control. Android Studio can import the project from only the gradle settings and build files, recreating the .idea folder, and this seemed like the best approach for a template project.

Are you saying that you do want parts of .idea under source control? The .idea folder was added to .gitignore by Android Studio's JetBrains template. Do you agree with the comments that were added by the JetBrains template, which would ignore much of .idea's contents, if for some reason the entire .idea folder were not ignored?

joebowbeer avatar Feb 10 '16 09:02 joebowbeer

Yes, every project has conventions and they are usually reflected in the IDE's settings, which is in this case the .idea folder.

I didn't know they had fallback defaults, and they seem to be fine indeed. So can you just remove line 37 from .gitignore and add back the files that are not ignored by the rest of it?

freezy avatar Feb 10 '16 09:02 freezy