VisualPinball.Engine icon indicating copy to clipboard operation
VisualPinball.Engine copied to clipboard

Physics engine uses different units for time

Open arthurkehrwald opened this issue 1 year ago • 1 comments

Seconds, milliseconds, and microseconds are all used in the physics code. Often without the variable names indicating what unit is used. This is tedious to work with because every time you work with a time variable you have to figure out what unit it is in. Is there any reason not to just use seconds for everything?

arthurkehrwald avatar Nov 11 '24 13:11 arthurkehrwald

Most of the physics code was ported 1:1 from VPX, so much of the nomenclature comes from there.

So no, there is no particular reason, certainly not deliberate, and yes, a PR to improve this is welcome. :)

freezy avatar Nov 11 '24 13:11 freezy