pyAPT icon indicating copy to clipboard operation
pyAPT copied to clipboard

Published 20 hours ago • verified publisher icon freespace

Add KDC101 controller

Open roflmaostc opened this issue 3 years ago • 1 comments

This basically fixes #14 for my special device. I only had to change a single value.

roflmaostc avatar Oct 19 '21 22:10 roflmaostc

Hi @roflmaostc ,

Thank you for this PR. 2 comments:

  1. you will note that your previous PR, https://github.com/freespace/pyAPT/pull/13, has been merged, and this PR seem to include the same changes again. Can you please rebase your branch such that this PR only includes code to introduce the new KDC 101 controller
  2. the KDC 101 is a controller that be used to control many different stages, all of which have their own settings. As such the controllers are stage-specific. For example you will note that the existing controllers mts50 and lts300 are both linear motion stages, not specific controllers. I suggest you rename the KDC101 class to be specific to the stage you are using instead.

freespace avatar Nov 15 '21 13:11 freespace