freeplane icon indicating copy to clipboard operation
freeplane copied to clipboard

Folding switch color: node background, instead of node border

Open euu2021 opened this issue 1 year ago • 7 comments

Discussed in https://github.com/freeplane/freeplane/discussions/1452

Originally posted by euu2021 October 7, 2023 First, some definitions: Apparently, there are two different elements in FP (as per Preferences…->Appearance->Size limits->Folding mark width and Preferences…->Appearance->Size limits->Folding switch width) :

  • Folding mark: the mark that shows that a node has children
  • Folding switch: the "button" that, once pressed, fold/unfold the node

My problem is that I use a dark background and dark node borders, so the Folding switch gets almost invisible: javaw_RsX1YHk3sN

In other words:

  • Folding mark is fine, because it follows the background color of the node
  • Folding switch is not fine, because it follows the node border, and gets almost invisible

Having a visible Folding switch is useful, to know if the node has children.

I tried using lighter colors for the node borders, but I really prefer black.

Feature request Issue:

Thanks,

euu2021 avatar Oct 07 '23 14:10 euu2021

Please upload an example map. Getting your ideas from screenshots is too hard for me.

dpolivaev avatar Oct 09 '23 11:10 dpolivaev

The colors are like this: EXAMPLE colors.zip

And I use a spotlight like this: image

euu2021 avatar Oct 09 '23 19:10 euu2021

If you use colors close to each other, then you are bound to have difficulties seeing them. It sounds to me that's a preference problem, not a Freeplane problem.

I also use exclusively dark mindmaps, and have not encountered this problem with the default line colors: 2023-12-12_105203_Screenshot -> 2023-12-12_105045_Screenshot

The fact that besides the color which is bright, the switch also change size on hover is very clear to show the call to action button. Anyway I do not want to discard your need (to each his own), so that's only my opinion :)

AlexandreBonneau avatar Dec 12 '23 20:12 AlexandreBonneau

If you use colors close to each other, then you are bound to have difficulties seeing them. It sounds to me that's a preference problem, not a Freeplane problem.

For my map, the dark border works much better than a light border. See comparison:

image

As you can see, it's much easier to tell the nodes apart when the border is dark.

And I don't like to use colors for the boders, because I use color coding in the map, so adding colors for the borders would result in a complete visual mess. My borders need to be in shades of grey.

euu2021 avatar Dec 14 '23 18:12 euu2021

  • Folding switch is not fine, because it follows the node border, and gets almost invisible

I think the "folding switch" is different when the node is folded than when the node is unfolded. unforlded: image

folded: image

I think what you want is that its format is in both cases like the "unfolded" one. not?

Maybe it was made this way, so it looks different to the "Folding Mark" (if the user choose similar widths)

EdoFro avatar Dec 14 '23 19:12 EdoFro

an idea:

unfolded "Folding Switch" (same as today):

  • border color = node's border color
  • fill color = node's background color

folded "Folding Switch" (change):

  • border color = node's background color
  • fill color = node's border color

EdoFro avatar Dec 14 '23 19:12 EdoFro

I personally think the current version works great and has been so for many years, so if you were to change it, please make it an option :)

AlexandreBonneau avatar Dec 15 '23 02:12 AlexandreBonneau