wave icon indicating copy to clipboard operation
wave copied to clipboard

Generate icons with Github Actions

Open lukahartwig opened this issue 4 years ago • 2 comments

Background

Our current flow for adding icons to the design system consists of:

  1. Designer provides icon as SVG
  2. Developer adds this icon to the assets/ folder
  3. Run script to generate React component
  4. Create PR
  5. Merge & Release

This takes time and slows us down.

Idea

Github allows uploading files through the UI so it is possible to upload an SVG directly through the website. This means a designer can handle this without having to touch git and checkout the code. When a new icon is uploaded we can trigger a Github Action to run the script to generate the component and create/update the PR with the new icon.

The new flow would look like this:

  1. Designer uploades icon as SVG to Github which triggers Action to generate the React component and opens a PR
  2. Maintainer reviews PR and merges to main (creating a automatic release with #38)

lukahartwig avatar Apr 23 '21 11:04 lukahartwig

@nlopin I see that the actions are setup and the pull requests are merged. Is this issue still relevant/do we need to setup anything additionally to what has been done?

lloydaf avatar Aug 02 '22 08:08 lloydaf

This issue is about the idea to have some sort of "self service" for designers to add new icons to the design system. I proposed using GitHub actions to automate this. As far as I can see this has not been implemented. The only Actions I see are related to tests and release.

lukahartwig avatar Aug 02 '22 09:08 lukahartwig