wave icon indicating copy to clipboard operation
wave copied to clipboard

Missing font weight Semibold (600)

Open div-Leo opened this issue 1 year ago • 3 comments

We're missing the font weight Semibold = 600

  • @freenow/wave version: latest

Relevant code

fontWeight: 'semibold' // not working

What was expected to happen?

It should render the text with font-weight:600 but is bolder than it should Expected size: Screenshot 2023-08-11 at 14 02 01

Reproduction

If you can, try to reproduce the issue in a Codesandbox. You can fork the one here: https://codesandbox.io/s/wave-playground-forked-fcv8tm?file=/src/App.js

div-Leo avatar Aug 11 '23 12:08 div-Leo

could you please assign me this task?

AditiChikkali avatar Feb 06 '24 18:02 AditiChikkali

I'm considering whether we should include the font in the library 🤔 What is your opinion? I think it removes the whole class of font-loading optimisations which are project-specific

nlopin avatar Feb 07 '24 11:02 nlopin

I'm considering whether we should include the font in the library 🤔 What is your opinion? I think it removes the whole class of font-loading optimisations which are project-specific

Including the font within the library may limit the ability to optimize font loading, if the font is to be included in the library, can we provide options for users to choose whether to include it or not?

AditiChikkali avatar Mar 25 '24 19:03 AditiChikkali