wave icon indicating copy to clipboard operation
wave copied to clipboard

fix(check-icon): remove fill none

Open arturmiglio opened this issue 2 years ago • 2 comments

What:

Fix the colour of the CheckIcon. ​ Why:

The CheckIcon svg tag has a fill none rule that makes it transparent in some situations.

How:

Remove fill='none' from the svg tag.

Media:

Screenshot 2022-10-04 at 12 08 18

arturmiglio avatar Oct 04 '22 10:10 arturmiglio

Those icons are auto-generated, I don't remember if the generate command deletes and replace the old icons when we add the new ones.

But in general, I see this possibly happening again. We should probably change it in the icon from Figma or the SVG itself.

div-Leo avatar Oct 06 '22 07:10 div-Leo

@arturmiglio can you reproduce this in a Sandbox so we can further investigate the source of the issue?

div-Leo avatar Oct 06 '22 09:10 div-Leo

@arturmiglio What is the status on this? Do we need anything else?

martimalek avatar Nov 17 '22 10:11 martimalek

@div-Leo @JanHamara @martimalek I've just had a chat with some PDs about this. More info on how will we proceed soon, after they have some time to analyse the issue and come up with a solution for the Icons exporting flow (let's call it like this, shall we?).

I'll keep you posted. Thanks!

arturmiglio avatar Jan 23 '23 11:01 arturmiglio

@artur-miglio-free-now any update on it? If not, we'll close the PR in two weeks

nlopin avatar Jun 29 '23 09:06 nlopin

@artur-miglio-free-now any update on it? If not, we'll close the PR in two weeks

Thanks for following up on this. I'll bring the topic back up with the PDs.

arturmiglio avatar Jun 29 '23 16:06 arturmiglio

I'll close it for now and re-open if that's the case. Please don't delete the branch though.

arturmiglio avatar Jun 29 '23 16:06 arturmiglio