wave icon indicating copy to clipboard operation
wave copied to clipboard

SelectList | Custom props not getting set

Open lloydaf opened this issue 2 years ago • 1 comments

  • @freenow/wave version:1.16.2

Relevant code

<SelectList
    data-id='bulk_action_select_box'
/>

What was expected to happen?

The data-id property should be set on the wrapper/div(s). Properties like id work (because it's explicitly being set).

The intention is to be able to set custom properties (in this case it's for GTM) for SelectList. Since we're not passing {...restProps} to Wrapper, it's not being set.

lloydaf avatar Nov 23 '21 09:11 lloydaf

I was working around this by using the id property instead, so it looks like this could still be a valid bug

lloydaf avatar Feb 24 '22 10:02 lloydaf