wave icon indicating copy to clipboard operation
wave copied to clipboard

TextButton documentation is missed

Open duranmla opened this issue 2 years ago • 3 comments

What was expected to happen?

Going to https://wave.free-now.com/ I am expecting to see TextButton but I don't. There is a hint they exist within the Playground at https://wave.free-now.com/components/button

Reproduction

Go to https://wave.free-now.com/components/button and there is no showcase for TextButton.

Question. Shall we create a new page to showcase the TextButton or within the same Button component page?

duranmla avatar Jul 05 '21 12:07 duranmla

@duranmla Since this is a variation of a button I guess it should be inside the button. Currently there we have a short not at the beginning:

Renders a button tag. This module exposes two types of buttons <TextButton /> and <Button />

and then an example in the Example block. But probably we could feature all the variants in the "Combinations" block.

@agonzalezUX what do you think?

rafael-sepeda avatar Jul 05 '21 13:07 rafael-sepeda

I've also herd from a developer in my team that they weren't aware of the text button. I'd suggest we either add a second documentation page (which I would prefer) or add a bigger section to the existing button documentation that explains the difference and has examples for both.

snapsnapturtle avatar Jul 05 '21 16:07 snapsnapturtle

@snapsnapturtle Good point. I would be in favour of the second option - adding a bigger section and list all the button types. In most design system there is usually one section for buttons:

rafael-sepeda avatar Jul 06 '21 08:07 rafael-sepeda