wininstaller-innosetup icon indicating copy to clipboard operation
wininstaller-innosetup copied to clipboard

Add 64-bit support

Open steveatinfincia opened this issue 7 years ago • 1 comments

  • adds support for 64-bit Windows and 64-bit Java
  • adds new wrapper binaries for 32-bit and 64-bit Windows, built by Travis CI
  • prevents existing installations from being overwritten if the installer is run multiple times
    • offers to run update.cmd instead
  • updates the bundled fred files to fred1478 (this should probably be changed to a common submodule of release files for all platforms)
  • updates the bundled .NET installer (see notes on wintray)

Note: The full 64-bit Java installer is included here, as there does not seem to be an online installer for the 64-bit version. The online 32-bit Java installer has also been updated to match.

steveatinfincia avatar Jul 15 '17 16:07 steveatinfincia

Don’t those release scripts already exist? On Mon, Nov 27, 2017 at 1:47 PM xor-freenet [email protected] wrote:

@xor-freenet commented on this pull request.

In install_node/FreenetTray.exe.config https://github.com/freenet/wininstaller-innosetup/pull/11#discussion_r153286842 :

  •        </setting>
    
  •        <setting name="UseBrowser" serializeAs="String">
    
  •            <value>Auto</value>
    
  •        </setting>
    
  •        <setting name="ShowSlowOpenTip" serializeAs="String">
    
  •            <value>True</value>
    
  •        </setting>
    
  •        <setting name="LogLevel" serializeAs="String">
    
  •            <value>Off</value>
    
  •        </setting>
    
  •        <setting name="CustomLocation" serializeAs="String">
    
  •            <value />
    
  •        </setting>
    
  •    </FreenetTray.Properties.Settings>
    

-

It would be nice to accompany this with a PR to the release scripts which builds the tray binary and puts it in the right place.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/freenet/wininstaller-innosetup/pull/11#pullrequestreview-79270911, or mute the thread https://github.com/notifications/unsubscribe-auth/ADEj2StFvySE7RJbR66TbEL8awkZKv0bks5s6wPTgaJpZM4OZECE .

freenet-bot avatar Nov 27 '17 20:11 freenet-bot