fred
fred copied to clipboard
freenet
Allow bdi and main elements and auto value of dir attribute
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/bdi https://developer.mozilla.org/en-US/docs/Web/HTML/Element/main https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/dir
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figure https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figcaption https://developer.mozilla.org/en-US/docs/Web/HTML/Element/mark https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ruby https://developer.mozilla.org/en-US/docs/Web/HTML/Element/rp https://developer.mozilla.org/en-US/docs/Web/HTML/Element/rt
This is a neat addition, but the added elements still need tests. I know that these can be annoying to write, since they feel obvious, but the last two times I omitted them and Bombe reminded me with an ENOTEST, one of those would have actually shown a bug (that luckily got found before merging when I added the test Bombe had requested).
⇒ please do test. These filters are critical for safe operation in browsers that may query into the clearnet on errors here.
Some more tests have been added. However, tests can only be written for expected inputs, but problems occur for unexpected inputs which cannot be tested before you find a problem! I already found two bugs that can crash the CSS validator within just a few days - very scary indeed!
Please note when you finished adding elements so I can review it again. (I need a stable state for reviewing)
New elements can then go into a separate additional PR/branch (rebasing that after this PR is merged should then make the other PR good).
Ok, I will freeze this one from now on. I do have further plans, but it seems getting code reviewed in this project is not as quickly as my first contribution being released in a new version in just a day. Hope you will have more free time in the future!
Checking MDN for updated elements and add them here usually takes just a small amount of time that could otherwise watch a video. But I am gonna watch videos as so many things are waiting to be merged.
Thank you! I’d love to be faster, but this is all volunteer-work by a handful of people that we can only do when we have the resources besides family and paying work. That’s why activity wanes and waxes depending on current energy levels.
I’d love to merge more quickly, but I have to review dilligently. We have to stay clear of the fine line between powerful CSS and accidental Turing Completeness (which would open up pages for attacks): https://beza1e1.tuxen.de/articles/accidentally_turing_complete.html ☺
I now reviewed all the commits since my last review ( https://github.com/hyphanet/fred/pull/990#issuecomment-2425690790 ). Once you address the comments, I’ll gladly merge to next.
(no need to address "good catch" ☺)
Thank you!