fred icon indicating copy to clipboard operation
fred copied to clipboard

Resilience against plugin list exception

Open ArneBab opened this issue 1 year ago • 1 comments

This is just a band-aid. We may want to copy the plugin list instead.

ArneBab avatar Apr 28 '24 15:04 ArneBab

Oof, yeah, that’s horrible. getLoadedPlugins() needs to make a copy. Actually, all the getters need to make copies. Who wrote that? (Oh yeah, it was me.)

Bombe avatar Jun 14 '24 09:06 Bombe

@Bombe I changed the getters to only return copies of the loaded and loading lists. They are only iterated over at all callers. And I found one instance where Toad was being rightfully paranoid about this :-) — now no longer needed.

Is this good to go?

ArneBab avatar Jul 09 '24 16:07 ArneBab

merged — thank you for the review!

ArneBab avatar Jul 25 '24 10:07 ArneBab