fred icon indicating copy to clipboard operation
fred copied to clipboard

M3u add parsing of forwarded header wip

Open ArneBab opened this issue 5 years ago • 7 comments

only merge after m3u is merged!

WIP, because parsing that header directly needs somewhat careful checking.

ArneBab avatar Sep 02 '20 22:09 ArneBab

only merge after m3u is merged!

I guess this could now use a merge or a rebase, whichever you prefer. :)

Bombe avatar Nov 29 '20 11:11 Bombe

Please don't mix formatting changes with code changes... it makes reviewing PRs such as this one very difficult

nextgens avatar Apr 06 '21 07:04 nextgens

First step: rebased and whitespace and imports cleaned up.

ArneBab avatar May 22 '22 08:05 ArneBab

Second step: more cleanup and some force pushing, because it should now be much easier to check.

ArneBab avatar May 22 '22 08:05 ArneBab

@Bombe I added tests and fixed the case sensitivity (keys must be insensitive). But this isn’t tested in production, yet.

ArneBab avatar Oct 14 '23 10:10 ArneBab

Hmm, according to RFC 7239 there can be multiple Forwarded headers in a request but I can’t spot any handling of that…

Bombe avatar Oct 14 '23 22:10 Bombe

@Bombe @ArneBab some news about his PR ? still relevant ?

hernic avatar May 06 '24 11:05 hernic