SSK inserts: commit before reply and collisions

[toad]

For review and careful testing. Two changes:

1. Always commit before sending InsertReply, just like we do in CHKInsertHandler (this is IMHO needed for consistency but it's also relevant to bug #3338, see the big comment).
2. Fix collisions not working correctly in some corner cases / race conditions.

[toad]

I would like this to be merged eventually. But it needs testing first, including in vitro. I will try it out in simulations...

[toad]

One thing that needs careful testing is whether this results in more forced disconnections. :(

[toad]

So far this works fine in one-request-at-a-time simulations. It will need testing more widely. This pull request is not urgent.

[toad]

Works fine in sequential simulations. Haven't tested more widely yet.

[bertm]

Except for some formatting issues this looks reasonable.

[toad]

I'm afraid I'm likely to ignore complaints that amount to "don't use Eclipse". :(

[Juiceman]

On Jan 31, 2016 12:39 PM, "Matthew Toseland" [email protected] wrote:

I'm afraid I'm likely to ignore complaints that amount to "don't use Eclipse". :(

—

Whatever happened to formatting the code base en masse?

Reply to this email directly or view it on GitHub.

[Thynix]

Automatic formatting isn't viable when there's a lot of existing code we still want to merge, which is currently the case for Fred.

On Sun, Jan 31, 2016, 3:49 PM Juiceman [email protected] wrote:

On Jan 31, 2016 12:39 PM, "Matthew Toseland" [email protected] wrote:

I'm afraid I'm likely to ignore complaints that amount to "don't use Eclipse". :(

—

Whatever happened to formatting the code base en masse?

Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/freenet/fred/pull/485#issuecomment-177606641.