fred icon indicating copy to clipboard operation
fred copied to clipboard

Fix burst only

Open toad opened this issue 10 years ago • 12 comments

Various cleanups, mostly directed at fixing logging errors. Relatively low risk but could conceivably change connectivity behaviour on non-NATed nodes.

toad avatar Aug 12 '15 20:08 toad

I've added a bunch more fixes, I think this is reasonable now. Please re-review. :)

toad avatar Aug 15 '15 12:08 toad

Yes, DarknetPeerNode's setStatus method calls PeerNode's setStatus and then changes the value in some cases. I will add some javadocs.

toad avatar Aug 15 '15 12:08 toad

I'll try not to add more unrelated bugfixes to this branch! Please review. Thanks.

toad avatar Aug 15 '15 12:08 toad

Anyone want to review this?

Thynix avatar Oct 11 '15 20:10 Thynix

@toad could you explain what the non-logging changes here do?

ArneBab avatar Nov 10 '15 13:11 ArneBab

Looks good to me

nextgens avatar Jan 04 '16 12:01 nextgens

Can I trouble someone to resolve the merge conflicts? I attempted fixing them but it wasn't exceedingly clear to me what was intended.

Thynix avatar May 14 '16 17:05 Thynix

Ping on those merge conflicts.

Thynix avatar Jul 18 '16 04:07 Thynix

Cough cough.

Thynix avatar Sep 15 '16 02:09 Thynix

ping on the merge conflicts from my side, too

ArneBab avatar Feb 20 '17 23:02 ArneBab

ping?

ArneBab avatar Apr 29 '19 21:04 ArneBab

@toad ping on the merge conflicts again

ArneBab avatar Jun 18 '22 16:06 ArneBab