Jeffrey Phillips Freeman
Jeffrey Phillips Freeman
@shabanovd and the bits size seems to get set here: https://github.com/Syncleus/aparapi-native/blob/29a057b0b231215986abcc97cda02b2aa66e5383/src/cpp/invoke/OpenCLJNI.cpp#L159
@shabanovd then the argDefs themself seem to come from here: https://github.com/Syncleus/aparapi-native/blob/29a057b0b231215986abcc97cda02b2aa66e5383/src/cpp/invoke/OpenCLJNI.cpp#L322 Which is ultimately determined from here: https://github.com/Syncleus/aparapi-native/blob/b7473d1f8a00284b56dfe7ec1185f70e9a1eedb6/src/cpp/invoke/OpenCLKernel.h#L25
@shabanovd yea that makes sense. I will give it a try and see if it passes tests. You have all the unit tests in your PR I can test against...
@shabanovd wonderful thanks. I'll edit the native code this evening and run the tests. If it works ill check it in. BTW if you feel compelled to do it yourself...
@shabanovd with your suggested edits to aparapi-native the compilation fails with the following results: ``` ibtool: compile: g++ -DPACKAGE_NAME=\"libaparapi\" -DPACKAGE_TARNAME=\"libaparapi\" -DPACKAGE_VERSION=\"1.2.1\" "-DPACKAGE_STRING=\"libaparapi 1.2.1\"" -DPACKAGE_BUGREPORT=\"[email protected]\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1...
@shabanovd Awesome, are all the tests passing now? Is the pr ready to accept/review?
@shabanovd sounds good. Let me know where I can help.
@shabanovd Any progress on this? I'm working on a new release soon and curious if i can help get this PR in on time or not.
@shabanovd No no specific deadline. Just want to make sure it stays active and synced with master.
@CC007 There is an easy path for this (run each kernel in its own cpu thread) but i dont like that. It should be possible to do from a single...