Sean Freeman

Results 171 comments of Sean Freeman

Note to self: `add_coords` for xarray fails when having coordinates to interpolate along dimensions other than x/y.

OK, I *think* I have resolved the datetime issues. It's somewhat of a hacky solution, but basically, `xarray` only converts to `datetime64` if the time received is in Gregorian time....

> Note to self: `add_coords` for xarray fails when having coordinates to interpolate along dimensions other than x/y. I have now also resolved this issue. The solution here results in...

@w-k-jones and @JuliaKukulies I am now ready for a re-review.

> > OK, I _think_ I have resolved the datetime issues. It's somewhat of a hacky solution, but basically, `xarray` only converts to `datetime64` if the time received is in...

> > > > OK, I _think_ I have resolved the datetime issues. It's somewhat of a hacky solution, but basically, `xarray` only converts to `datetime64` if the time received...

OK, changes all merged in and everything. @JuliaKukulies and @w-k-jones are you happy for me to merge into `RC_v1.6.0`?

Thanks, @JuliaKukulies and @fsenf . We have one minor merge conflict to fix, but I would also be happy for this to be merged directly into `main` as it only...

> All right, I fixed the json formatting issue, so I am merging directly into `main` as we have discussed before. Thanks @fsenf and @freemansw1 and lets make sure to...

Yes, this is a good idea, although we will need to (or we should, at least) address the fact that we don't currently have an in-built `hdim_1`/`hdim_2` to dimension/coordinate mapping....