Sean Freeman

OK, I'm working on more thoroughly testing this now that #354 is merged. One issue that I'm consistently noticing is issues between nanosecond/microsecond conversions. This is a note to myself...

Okay, this is now ready for review in my opinion. This PR contains changes from #380. I'd like feedback (and testing) everywhere, but in particular, I'd like feedback on the...

> > Okay, this is now ready for review in my opinion. This PR contains changes from #380. > > I'd like feedback (and testing) everywhere, but in particular, I'd...

> Could this be solved using [DataArray.swap_dims](https://docs.xarray.dev/en/latest/generated/xarray.DataArray.swap_dims.html)?: > > ``` > variable_da = variable_da.swap_dims({"time":"frame", "south_north":"hdim_1", "west_east":"hdim_2"}) > variable_da.interp( > coords=dict( > frame=xr.DataArray(Features["frame"].values, dims="feature"), > hdim_1=xr.DataArray(Features["hdim_1"].values, dims="feature"), > hdim_2=xr.DataArray(Features["hdim_2"].values, dims="feature"), >...

Note to self: this depends on #380 to merge.

Got about halfway through the review comments... Next few will take a bit longer.

OK, I have resolved all review comments here. @w-k-jones ready for a second review. We will need another review from someone else, too, but this is not urgent as I...

> Great, thanks for making the revisions. I've had a look through the changes and tested the code with both xarray and iris locally and have no issues to issues....

Ok, @JuliaKukulies, I think I've addressed your concerns. Ready for your re-review. Hopefully we can get this merged!

> Excellent, @freemansw1! This looks good except for that there is still the issue with `preserve_iris_datetime_type` which does not result in the same datetime format as when I provide iris...