Sean Freeman

Results 171 comments of Sean Freeman

We did not agree on a format yet for the dev guide, and putting it in the RTD page makes a lot of sense. Also should make sure to explicitly...

For #354, I'm working on a modification to the decorators that passes an optional hidden kwarg that notes whether an `iris`->`xarray` conversion occurred, to hopefully help with some of these...

> Sounds like a good plan. Would it make sense to split the decorator changes into a separate branch/PR so they can be worked on concurrently with converting other sections...

> > Sounds like a good plan. Would it make sense to split the decorator changes into a separate branch/PR so they can be worked on concurrently with converting other...

Ok, @fsenf, I believe I've addressed your comments and I am now ready for a re-review.

FWIW, I now have a mostly working copy of feature detection fully transitioned to xarray from iris, using many of the same principles as discussed here, including a migration of...

The codecov results indicate to me that we will need to specifically exclude the versions of xarray/iris that cause a conversion incompatibility when we release 1.6.0.

Note: 360 day calendar issues and times not matching up between feature detection and segmentation

Thanks, @JuliaKukulies . I'm hesitant to mark this ready for review until #354 is merged, but happy for you to look into the bulk statistics issue.