Sean Freeman

Results 171 comments of Sean Freeman

Thanks for doing this, @snilsn . My initial review is to approve these without changes, but I do want to take the time to check what happens if we port...

Good point, @snilsn. And implementing these won't impact the user-facing code for now anyway, so I've approved the PR.

Good points, and good change @snilsn ! I expect that we may modify these functions in 1.6+ as we start getting everything integrated, but good to start checking/integrating these now....

I think the template in tobac-tutorials is a good one, and switching our templates to be more like that is a good idea in my mind.

Good catch @JuliaKukulies ! It looks like Docker captured the warning, but users more generally wouldn't see it. I spun up a new environment and tried to install it with...

> Also, do I understand it correctly that you propose to already now require >3.7 for conda so that users who install tobac v1.4.0 via conda would need to do...

Thanks! Agreed with you @JuliaKukulies . If users are still on Python 2.7 or

You are totally right, @JuliaKukulies . I had completely missed it when merging in because it's at the top/is not a keyword argument. My apologies!

Entirely agreed. This is a key component of being good citizens of FAIR principles (https://www.go-fair.org/fair-principles/). #354 doesn't necessarily get us all the way there for that; our feature detection output...

I haven't started reviewing this yet, but I wonder if we shouldn't try to push this to v1.5.3? I'm starting to get antsy about v1.5.2 coming out.