Sean Freeman

Results 171 comments of Sean Freeman

I think switching to imports at the top of functions, in general, makes sense. The two situations where I see where importing inside functions as advantageous are: 1. If a...

So while our overall code coverage number is pretty poor, our code coverage on the most important modules (feature detection, segmentation, tracking) is actually pretty good. I wouldn't be opposed...

Okay, to do this we will need to do the following (as far as I can tell from googling): - [x] Set the version requirements in `setup.py` (see, e.g., https://stackoverflow.com/a/45781701/629110...

We've now added the deprecation warning on import (#193), so the next step is to update the meta.yml file, which I'll do on release of 1.4.

I'm happy with your changes and happy for you to merge once @snilsn has a chance to look things over.

I should note that the only actual code change that should be here is the deletion of the two commented out functions in `uitls.py`. I didn't see much of a...

Yes, what @JuliaKukulies says is exactly the reason that I structured the code the way that I did. Any functions that were exposed via `import tobac` are still exposed to...

After thinking about it some, I've added the two functions mentioned above to `tobac.utils` such that no code (should) be broken. I've also addressed @snilsn's comment on deleting the not...

Good catch, @JuliaKukulies . I've added the `tobac.utils.general` and `tobac.utils.mask` modules to the API reference, but not the `tobac.utils.internal`, on the theory that internal utils shouldn't be used by users...

With us accidentally breaking compatibility in #175, I've tagged this to be done in v1.5, which is when we drop support for On the same note, we could also test...