Java-Android-Magisk-Burp-Objection-Root-Emulator-Easy icon indicating copy to clipboard operation
Java-Android-Magisk-Burp-Objection-Root-Emulator-Easy copied to clipboard

JeffHicks Suggestions

Open freeload101 opened this issue 1 year ago • 0 comments

@operat0r I took a quick glance. My suggestions to improve this: Get-WMIObject should be considered deprecated. Use Get-CimInstance. Don't turn off errors. Use proper error handling with Try/Catch. Use Join-Path instead of concatenation.

Apr 2 JeffHicks Jeff Hicks 🐶🎼🍷🖥️ @JeffHicks @operat0r I think you should make this a proper PowerShell module. Break out each function to a separate file. Use proper function names. Create a manifest. Add proper help documentation for each command.

freeload101 avatar Jun 04 '24 08:06 freeload101