juriscraper icon indicating copy to clipboard operation
juriscraper copied to clipboard

Small Type fixes

Open Brennan-Chesley-FLP opened this issue 2 months ago • 1 comments

This is a collection of small changes to type annotations (and a couple of type stub imports) that should address ~1/3 of the type errors for the repo. Commits should be small and of the same general type of fix.

Brennan-Chesley-FLP avatar Dec 03 '25 21:12 Brennan-Chesley-FLP

@Brennan-Chesley-FLP I noticed that the uv.lock file was still much larger compared to the one I generated locally. So I pushed my uv.lock. I’m not sure what’s causing the difference, but I only installed the dependencies independently, like:

uv add --dev "mypy>=1.19.0"
uv add --dev "types-python-dateutil>=2.9.0.20251115"
uv add --dev "types-requests>=2.32.4.20250913"
uv add --dev "types-lxml>=2025.11.25"

Here is the difference before and now: Screenshot 2025-12-12 at 2 27 10 p m

Screenshot 2025-12-12 at 2 27 24 p m

It seems there is still an unresolved suggestion.

Also, what do you think about adding mypy to the Contributing.md file as suggested in: https://github.com/freelawproject/juriscraper/pull/1685#pullrequestreview-3555848567 ?

So other developers can verify their types when working on new modules and help achieve higher typing coverage in the repo.

albertisfu avatar Dec 12 '25 20:12 albertisfu

rebased on main and added a note to CONTRIBUTING.md .

Brennan-Chesley-FLP avatar Dec 16 '25 00:12 Brennan-Chesley-FLP

This should only have one assignee at a time, unless there's something that requires working together. It looks like this one is ready for Alberto, so I removed you from it, Brennan.

mlissner avatar Dec 20 '25 17:12 mlissner