Don't set court='scotus' for South Carolina citations #84

[devlux76]

This addresses issue #84. The issue was caused because SC is treated differently than S.C. when searching and scotus is the default return result. Since all court strings are unique with or without punctuation, stripping all punctuation and converting to the same case allows for an exact comparison instead of the "startswith" comparison that was previously being used.

[CLAassistant]

All committers have signed the CLA.

[mlissner]

@jcushman do you have any bandwidth or interest in taking a look at this one?

@devlux76, thanks! Looks like you need to do a little linting work now that tests have completed though.

[devlux76]

@mlissner I'm sorry, I don't understand.

Looks like you need to do a little linting work now that tests have completed though.

Can you please give me more info about what needs to be done here? Thanks!

[mlissner]

Linters are programs that check your work to make sure it's clean and pretty and using best practices. We have a few of them that were in Github Actions, but we didn't have a good process for developers to actually run them, so I just added a dev dependency for pre-comit to this branch. We use this in most of our other projects, so it seems reasonable to use it here too.

After adding it, I ran it, it cleaned up and highlighted a few problems with your code, which I fixed for you.

So this is ready for review again, but I'll wait for Jack to see if he wants to look at it. If not, I'll jump back in.

[devlux76]

Ok, I understand on the linting. I guess I'm so used to golint autoliniting my code that I forgot python doesn't do this automatically.

So for future reference, is there a particular process I should use prior to committing?

[mlissner]

If you run pre-commit install in your repo, it'll install a git hook that runs the pre-commit checks before each commit. If it fails, some things (like formatting) will be fixed automatically, and you can just re-run your git commit. Other things will report errors you'll have to fix yourself. But that's the heart of it, and you'll write better code as a result.