eyecite icon indicating copy to clipboard operation
eyecite copied to clipboard

MAX_OPINION_PAGE_COUNT ?

Open devlux76 opened this issue 3 years ago • 1 comments

I was doing a code review in preparation for the fix I was asked to work on regarding "scotus" being assigned inappropriately to certain cases. While reading the code I noticed the following line in resolve.py

MAX_OPINION_PAGE_COUNT = 150

I was wondering why the 150-page limit when there are cases like McConnell v. FEC, 251 F.Supp.2d 176 (D.C. 2003) that are 750+ pages long. While probably not the majority of cases, some of the more important cases are well in excess of 150 pages and we might be missing out on citations to them by bailing out if the pincite is > page+150 in the _has_invalid_pin_cite function?

devlux76 avatar Dec 25 '21 01:12 devlux76

This is a judgement call. See discussion here: https://github.com/freelawproject/eyecite/issues/74

mlissner avatar Dec 27 '21 20:12 mlissner