courtlistener
courtlistener copied to clipboard
feat(recap): Add suport to parse ACMS attachment pages
This PR introduces the logic to process attachment pages from ACMS. Here's a breakdown of the key changes:
-
New Upload Type: A new upload type named
ACMS_ATTACHMENT_PAGE
is added to theProcessingQueue
andpacerhtmlfiles
model. -
A new helper method
process_recap_acms_appellate_attachment
is introduced. This method encapsulates the logic for parsing, processing, and merging ACMS attachment pages. -
The
PacerDocIdLookUpSerializer
class is updated to include theacms_document_guid
field in its response. This field is crucial for matching documents within the attachment page and generating the recap icon in ACMS. -
Factories are added to mock the dictionary returned by Juriscraper methods. Additionally, tests are included to verify the functionality of the new features.
@grossir, can you please review again before I take another look? It's been a month or two and it looks like we've got some changes.
Thank you!
The model changes are noops. Would it be possible to rename them to something like 123_add_upload_types_noop.py/sql, so that those of us doing deployments (and those inspecting migrations later) can see that they're not changing the DB? I think this is in our dev guide as a best practice, but if not, we should probably add it.
Would it be possible to rename them to something like 123_add_upload_types_noop.py/sql
Sure!
I think this is in our dev guide as a best practice, but if not, we should probably add it.
You're right, it is described in the "Steps to making new migrations" section of the Database Migrations wiki page.