freeipa-webui icon indicating copy to clipboard operation
freeipa-webui copied to clipboard

Adjust some of the other components like `ManagedByToolbar` or `ManagedByAddModal` to do a single concern

Open carma12 opened this issue 1 year ago • 1 comments

The interface of the ManagedByAddModal is kinda hard to understand when we don't know the implementation.

E.g. I'd expect to have something like:

<AssociationAddModal
   chosenEntries={managedByHosts}, // containing list of { key: host.uid, value: hostName }
   availableEntriesLoader={functionToProvidePromiseOfListOfAvailableHosts} // promise would return same data structure as ^^
   onSelectionChange={callback(selectedEntries)}
   title="string"     
/>

This would be usable for all the simple associations.

Originally posted by @pvoborni in https://github.com/freeipa/freeipa-webui/pull/67#discussion_r1172435486

carma12 avatar May 04 '23 12:05 carma12

This issue has not received any attention in 120 days.

github-actions[bot] avatar Dec 11 '23 12:12 github-actions[bot]