sunder icon indicating copy to clipboard operation
sunder copied to clipboard

Support saving MIME types in shares

Open GabeIsman opened this issue 7 years ago • 4 comments

This is a feature that @FredericJacobs has already added to rusty-secrets but isn't yet supported in the app. Shouldn't be too difficult, but I also don't think it should block launch.

GabeIsman avatar Jun 09 '17 01:06 GabeIsman

@GabeIsman Do you need anything from @FredericJacobs to implement this? I agree this would be a nice feature to have, but I don't think it's critical for 1.0.

garrettr avatar Jun 15 '17 23:06 garrettr

We already have support for this in RustySecrets so I don't think so.

FredericJacobs avatar Jun 16 '17 14:06 FredericJacobs

Yup! As I noted above, this ready for UI implementation.

GabeIsman avatar Jun 16 '17 16:06 GabeIsman

I have this implemented in a branch, but it's blocked on #141 which simplifies the file input component somewhat.

One question I have is what to do with the mime type on the recover/export side. One obvious feature would be to infer the file extension when saving the recovered secret file to disk.

We could also consider rendering the file since electron/chrome is pretty good at displaying images, pdfs, html documents, etc.., given a mime type, but since that is tantamount to embedding remote content, we would need to be very careful to mitigate against malicious inputs.

liliakai avatar Sep 28 '18 12:09 liliakai