securedrop icon indicating copy to clipboard operation
securedrop copied to clipboard

Persist onion addresses with "make dev-tor"

Open deeplow opened this issue 4 months ago • 1 comments

Makes the SecureDrop Workstation dev workflow easier by removing the need to setup standalone server VMs if one wants a persistent server address and authentication token.

The solution involves creating a docker volume. This will persist as long as the user does not manually remove it or moves to another system without porting the volume. Since this a dev environment, long term persistence should not be a concern, so this solution sufices.

Fixes #7115

Status

Ready for review

Description of Changes

Fixes #7115.

Changes proposed in this pull request:

Testing

Run make dev-tor multiple times and ensure that the same journalist config is generated.

Deployment

Any special considerations for deployment? no

Checklist

If you made changes to the server application code:

  • [ ] Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

  • [ ] Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you added or removed a file deployed with the application:

  • [ ] I have updated AppArmor rules to include the change

If you made non-trivial code changes:

  • [ ] I have written a test plan and validated it for this PR

Choose one of the following:

  • [ ] I have opened a PR in the docs repo for these changes, or will do so later
  • [ ] I would appreciate help with the documentation
  • [ ] These changes do not require documentation

If you added or updated a reference to a production code dependency:

Production code dependencies are defined in:

  • admin/requirements.in
  • admin/requirements-ansible.in
  • securedrop/requirements/python3/requirements.in
  • securedrop/requirements/python3/translation.in (used in the build container)

If you changed another requirements.in file that applies only to development or testing environments, then no diff review is required, and you can skip (remove) this section.

Choose one of the following:

  • [ ] I have performed a diff review and pasted the contents to the packaging wiki
  • [ ] I would like someone else to do the diff review
  • [ ] I am silencing an alert related to a production dependency, because (please explain below):

deeplow avatar Feb 29 '24 18:02 deeplow