securedrop-client

securedrop-client copied to clipboard

we are checking auth state on controller in multiple ways

2

We currently have multiple ways we determine whether or not the Controller object is in an authenticated state: * `is_authenticated` - property (which has a private attribute of its own...

redshiftzero

remove ConversationView.add_reply_from_reply_box

1

do we really need [`add_reply_from_reply_box`](https://github.com/freedomofpress/securedrop-client/blob/master/securedrop_client/gui/widgets.py#L2843)? This is one path to widgets getting added to the conversation view outside of calls to `update_conversation`. It seems unnecessary now: in `on_reply_sent` [here](https://github.com/freedomofpress/securedrop-client/blob/master/securedrop_client/gui/widgets.py#L2865) we...

redshiftzero

Cancel pending replies

7

# Description This issue is a place to capture thoughts on whether or not we should provide a cancel option for pending replies, and if we do, what that would...

sssoleileraaa

# Description Either remove `PauseQueueJob` since it's currently unnecessary or re-implement having the queue manager pause both queues when a `RequestTimeoutError` is encountered. I think this should be discussed more...

sssoleileraaa

Consider not running new syncs if jobs from previous sync are still active

2

We now kick off metadata syncs continuously, which is great. This also happens if we're still downloading replies/messages from a previous sync. This causes some additional complexity: - We'll need...

eloquence

Disable Auth Widget when no connection

2

## Problem When there is not a connection or when the user is offline, the SD server cannot be reached- and as such, the user cannot log out. ## Solution...

ninavizz

support duplicate HTTP headers

2

## Description During #1778, I've been [reminded][HeaderDict] that HTTP permits both requests and responses to have duplicated headers—that is, to have multiple values for the same key. We should make...

cfm

Bump debhelper compat version from 11 to 12

2

# Description When we bump the debhelper compat version from 11 to 12, CI for workstation components break. We are able to repro by first creating the tarball in the...

sssoleileraaa

Ship release key in /usr/share/keyrings instead of /etc/apt/trusted.gpg.d

1

Per team conversation today: The ultimate strategy for addressing freedomofpress/securedrop-builder#450 will be to change the location of our release signing key to `/usr/share/keyrings` and change the apt-sources entry to `deb...

rocodes

teach `vcrpy` our proxy v2 request/response semantics

4

Tests need fixing, they're currently using `vcr`. We either need to reimplement vcr for our mock format or mock the proxying to use requests and then keep using vcr. _Originally...

cfm