freedomofpress
Clarify Attachment Indicator in List Items
Description: It seems that all list items currently have an attachment icon, but there is no indication of how many attachments are associated with each item. If every item has an attachment, the icon becomes somewhat redundant.
Suggested Improvement:
-
Consider adding a counter next to the attachment icon to indicate the number of attachments per item.
-
Alternatively, if all items have an attachment, the icon could be removed or replaced with a more informative indicator
This would improve the clarity of the interface and reduce any unnecessary visual clutter.
(Hey @avocadodavinci - adding this to the tracker and moving it to the securedrop-client repo, just because that's where the likely code changes would live.)
IIRC in general, sources may not necessarily have attachments. If they've only submitted messages, the paperclip icon should not be present. If you're running the dev demo instance, you can create a new source and submit text messages only to see the difference.
IIRC in general, sources may not necessarily have attachments. If they've only submitted messages, the paperclip icon should not be present. If you're running the dev demo instance, you can create a new source and submit text messages only to see the difference.
I get that, I think there are a few potential solutions. I think the visual hierarchy might also be a little off. For comparison, this is how an email in ProtonMail looks with an attachment:
If we keep the behaviour as is, I'd recommend a little visual refresh on the layout and size of the date and icon. I have a few ideas I want to explore as a proof of concept.
https://github.com/freedomofpress/securedrop-client/pull/2395 is likely relevant if you're looking at the date as well. Take a look at the proposed change there.
#2395 is likely relevant if you're looking at the date as well. Take a look at the proposed change there.
That's helpful, thanks. It should not affect a potential proposed change there.
The problem we'd try to solve here is to make the "metadata" such as "is there an attachment or not" less dominant in the UI. This could be done as an iterative improvement: reduce attachment size and change placement, more subdued color, etc.
It could be done as part of a general list view refresh, which could incorporate changes to timestamp display (#2395).
I have an initial prototype read for the download attachment component and behaviour ready.
The design is adapted to the current UI style and I would recommend updating this at the point we are revisiting the UI style in general. @eloquence I'd appreciate a review from the team here so we can move forward with implementing this. Let me know if I have missed any scenario here.
You can see the clickable prototype in action here: https://ura.to/attachment-ux
Here is also a screen recording of the component:
https://github.com/user-attachments/assets/8cb803d2-2e39-4766-9a90-7fad8086345a
Thanks much for the work on this @elioqoshi. Let's take the discussion to #1104 which is the main issue we're using specifically for the download progress UX (this issue is focused on the attachment indicator). I've copied your comment above over there.