reply box loses focus after sending

[cfm]

Description

After sending a reply with <Ctrl>-<Enter>, the reply box loses focus.

Steps to Reproduce

1. Type a reply.
2. Press <Ctrl>-<Enter> to send.

Expected Behavior

The reply box regains focus (i.e., for a subsequent reply).

Actual Behavior

The reply box loses focus.

Comments

The chat UX idiom encourages people to (think they can) send multiple short messages in rapid succession, which is clumsy if the reply box can be submitted with the keyboard but must regain focus via the mouse.

[rocodes]

It looks like this may be intentional(ish) behaviour, or behaviour we haven't standardized on:

https://github.com/freedomofpress/securedrop-client/blob/d94eca34a2f530c7286e5463bde64ef0fc73f878/client/securedrop_client/gui/widgets.py#L3166-L3167

Originally I think this was introduced to avoid the replybox losing focus if a user was using the replybox while a background sync was applied. But a side-effect is the behaviour you mention (the replybox requires mouseclick or inconvenient tab/keyboard navigation in order to be refocused).

I think it's a fair point - it's inconvenient to get back to the replybox without using the cursor. I would say we should keep this open but not treat it as a release blocker - it's not a regression but we should put more time into all of our accessibility/navigation behaviours and making them consistent/predictable. That work for you @cfm ?

[cfm]

Oh, I absolutely agree that this is a long-standing UX inconsistency, neither a regression nor (remotely) a release blocker.

[eloquence]

This will be addressed in the rewrite.