securedrop-client
securedrop-client copied to clipboard
freedomofpress
always use a temporary directory when downloading files and replies
Description
Rather than defaulting to either ~/QubesIncoming or ~/Downloads or taking an explicit path only under test, API.download_{reply,submission}() should always save a file to a temporary directory provided by the caller.
How will this impact SecureDrop users?
No user-facing impact.
How would this affect the SecureDrop Workstation threat model?
No threat-model implications.
One reason to make this change is so that the branch (code-path) we test is actually the branch we care about, as demonstrated by the test-level changes in 18e19c3bda92c3131a3438e584e50c99de95bf89.
@cfm I think this can be closed now and considered in the context of #2471 - do you agree?
