securedrop-client icon indicating copy to clipboard operation
securedrop-client copied to clipboard

No longer create a new thread for every login or logout request in the same session

Open sssoleileraaa opened this issue 5 years ago • 1 comments

Description

Right now, we start a new thread for every login or logout attempt. Since we don't need to support concurrent login and logout requests in the client, we could just have one thread that handles authentication. This is also a good opportunity to refactor, e.g. we currently store the thread ids in a dict so that we can get the current_object in success and failure handlers yet current_object will always be None.

sssoleileraaa avatar Jul 22 '20 19:07 sssoleileraaa

Zooming out: Are there other API calls like login and logout that we fire off individually like this, rather than enqueuing on one of the job queues? Ideally we would generalize a mechanism for doing so, rather than special-casing the login and logout requests.

cfm avatar Aug 22 '24 17:08 cfm

Closing all refactoring/re-architecting issues pertaining to the old codebase since we're focused on the Electron rewrite.

eloquence avatar Jun 30 '25 23:06 eloquence