securedrop-client icon indicating copy to clipboard operation
securedrop-client copied to clipboard

Fix any broken commented out integration tests

Open sssoleileraaa opened this issue 5 years ago • 1 comments

Description

#1082 aimed to get as much UI test coverage in one PR as possible. There are some comments in the test code that need to be addressed. For instance:

    # assert (40, 0, 40, 0) == modal_dialog.header_line.getContentsMargins()

This should be true, but there could be a typo or something wrong with how we're testing this. We also might need to use pyautogui, which should be determined as part of resolving this issue.

Look for comments that start with assert to indicate what should work but doesn't (we were able to manually confirm that the application worked as expected so afaik these are test-specific errors).

Follow up from: #1082

sssoleileraaa avatar May 23 '20 00:05 sssoleileraaa

To be revisited:

  • commented out assertions should be checked and either fixed, or deleted if not relevant/important.

zenmonkeykstop avatar Aug 15 '24 18:08 zenmonkeykstop

Closing, non-critical issue specific to the current codebase/UX, which is undergoing a rewrite.

eloquence avatar Jul 03 '25 21:07 eloquence