gotham-grabber icon indicating copy to clipboard operation
gotham-grabber copied to clipboard

PR

Open nzewail opened this issue 4 years ago • 2 comments

I added support for a couple of websites and wanted to open a PR to commit those changes to master but said I was denied permission. Is there anyway I can get permission to this repo?

nzewail avatar Jan 20 '21 03:01 nzewail

Hi @nzewail, thanks for taking a look at this! Although this project isn't under very active development, I would happily take a look at a pull request if you could create it from your own fork, instead of from a branch in this copy.

That will have two benefits: first, we won't have to modify any permissions in order to allow it, and second, your fork will be publicly available in case there are components you want to support but that we can't merge in for whatever reason.

thisisparker avatar Jan 20 '21 19:01 thisisparker

Cool! Opened a PR #14

nzewail avatar Jan 21 '21 22:01 nzewail