dangerzone icon indicating copy to clipboard operation
dangerzone copied to clipboard
verified publisher icon freedomofpress

Wrong permissions on built Fedora artifacts.

Open apyrgio opened this issue 1 year ago • 6 comments

While testing the produced RPMs for the 0.6.0 release, we stumbled upon this issue on Fedora 39 (Fedora 38 is also affected):

image

It seems that the produced RPMs have wrong permissions (current: rw------- / 600, expected: rw-r--r-- / 644), specifically on the following files:

dangerzone/conversion/common.py
dangerzone/conversion/doc_to_pixels.py
dangerzone/conversion/pixels_to_pdf.py
qubes/dz.Convert
qubes/dz.ConvertDev

While rebuilding the RPMs, we see the following warnings in the logs:

*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone-0.6.0.dist-info/LICENSE is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone-0.6.0.dist-info/WHEEL is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone-0.6.0.dist-info/entry_points.txt is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone-0.6.0.dist-info/INSTALLER is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone-0.6.0.dist-info/METADATA is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/util.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/__init__.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/logic.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/container-pip-requirements.txt is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/cli.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/document.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/gui/main_window.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/gui/__init__.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/gui/updater.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/gui/logic.py is executable but has no shebang, removing executable bit
mangling shebang in /usr/lib/python3.12/site-packages/dangerzone/conversion/doc_to_pixels.py from /usr/bin/env python3 to #!/usr/bin/python3
mangling shebang in /usr/lib/python3.12/site-packages/dangerzone/conversion/common.py from /usr/bin/env python3 to #!/usr/bin/python3
mangling shebang in /usr/lib/python3.12/site-packages/dangerzone/conversion/pixels_to_pdf.py from /usr/bin/env python3 to #!/usr/bin/python3
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/conversion/errors.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/settings.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/args.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/errors.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/isolation_provider/qubes.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/isolation_provider/container.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/isolation_provider/dummy.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/lib/python3.12/site-packages/dangerzone/isolation_provider/base.py is executable but has no shebang, removing executable bit
*** WARNING: ./usr/share/applications/press.freedom.dangerzone.desktop is executable but has no shebang, removing executable bit
*** WARNING: ./usr/share/dangerzone/image-id.txt is executable but has no shebang, removing executable bit
*** WARNING: ./usr/share/dangerzone/dangerzone.css is executable but has no shebang, removing executable bit
*** WARNING: ./usr/share/dangerzone/version.txt is executable but has no shebang, removing executable bit
mangling shebang in /etc/qubes-rpc/dz.ConvertDev from /usr/bin/env python3 to #!/usr/bin/python3
mangling shebang in /etc/qubes-rpc/dz.Convert from /bin/sh to #!/usr/bin/sh

We can see here that the files with the wrong permissions are the ones whose shebang has been mangled. The Fedora docs further explain this operation: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines

What's interesting though is that this warning is not present in the CI job that builds RPMs, nor is it reproduced locally: https://github.com/freedomofpress/dangerzone/actions/runs/8041707585/job/21961324246#step:5:207.

apyrgio avatar Feb 26 '24 14:02 apyrgio

Interesting and great that we caught this prior to shipping.

deeplow avatar Feb 26 '24 14:02 deeplow

One factor that may contribute to this is the difference in the base images. The Fedora image differs if you build the development environment through Podman instead of Docker. In Podman, the Fedora image is grabbed by registry.fedoraproject.org/fedora, whereas in Docker, it's fetched by docker.io. In this particular case, the offending RPMs are built in Docker, whereas our CI and my local environment uses Podman.

Turns out that these two base images do differ from each other, albeit in small ways. Still, using the (seemingly working) Fedora image from registry.fedoraproject.org/fedora does not fix this bug. It does fix another issue (we stumbled again on #675 in our Docker environment for no reason), but the resulting RPM is still corrupted.

apyrgio avatar Feb 26 '24 15:02 apyrgio

I have some updates here.

(1) It affects also Fedora 38 (and the Qubes versions)

(2) Shebang WARNING is unrelated

I think the shebang warning line is unrelated. After adding those, the permissions remain wrong. After all it only mentions affecting the executable bit -- not the read permissions. However it does show that there are some differences in the Docker-packaged Fedora version and the one provided by Podman...

(3) More files are affected

It seems that the produced RPMs have wrong permissions (current: rw------- / 600, expected: rw-r--r-- / 644), specifically on the following files:

dangerzone/conversion/common.py dangerzone/conversion/doc_to_pixels.py dangerzone/conversion/pixels_to_pdf.py qubes/dz.Convert qubes/dz.ConvertDev

Actually, I think we have more affected files:

  • (current: rw------- / 600, expected: rw-r--r-- / 644) - all .py files within /usr/lib/python3.{11,12}/dangerzone/
  • (current: rw------- / 600, expected: rwxr-xr-x / 755) /etc/qubes-rpc/dz/Convert{,Dev}

deeplow avatar Mar 05 '24 10:03 deeplow

Turns out that these two base images do differ from each other, albeit in small ways. Still, using the (seemingly working) Fedora image from registry.fedoraproject.org/fedora does not fix this bug. It does fix another issue (we stumbled again on https://github.com/freedomofpress/dangerzone/issues/675 in our Docker environment for no reason), but the resulting RPM is still corrupted.

I tried now building on my linux system with podman, but using the docker.io registry instead (by editing the fedora listing in the shortnames /etc/containers/registries.conf.d/000-shortnames.conf) and the final version worked well. So somehow this is a difference with how Docker and Podman works...

deeplow avatar Mar 05 '24 11:03 deeplow

Turns out that these two base images do differ from each other, albeit in small ways. Still, using the (seemingly working) Fedora image from registry.fedoraproject.org/fedora does not fix this bug.

We ran into this as well (https://github.com/freedomofpress/securedrop-workstation/issues/912) but at the time I couldn't find any practical differences in the two images.

legoktm avatar Mar 05 '24 19:03 legoktm

Well, turns out that FUSE is the culprit, when it's used to mount directories to the containers. If we move the rpm-build/ directory outside the mounted volume, then the permissions are correct.

apyrgio avatar Mar 05 '24 21:03 apyrgio

This issue has bit us again. In order to fix it, I propose doing the following:

  1. Detect in our RPM .spec file if the created package contains any files with wrong permissions (0600 / -rw-------). If that's the case, throw an error and give some context to the user.
  2. Fix any incorrect shebangs that need to be mangled in any case.
  3. Make package building take place in a directory that's not mounted by FUSE. Since the dangerzone/ directory is mounted in the container, it has to happen somewhere else. The canonical place for RPM building is ~/rpmbuild, so we plan to go with that.

apyrgio avatar May 28 '24 08:05 apyrgio