pkg icon indicating copy to clipboard operation
pkg copied to clipboard

external/blake2: use C99's inline keyword for inlining

Open rilysh opened this issue 1 year ago • 2 comments

I'm aware that blake2 comes from an external repository, but the official implementation that pkg uses, hasn't seen an update for over 6 years (8 years for pkg repository) and no overall activity for over a year. There's, however, another repository, that implements the same blake2, with additional cleanups, but it also removes some functions (e.g. *16, load16, store16, etc.). Since the current implementation is quite right already, I personally don't think it need to be replaced.

Commit: https://github.com/freebsd/pkg/commit/475f1e2123bf1dcb1f6a191b964b0cbc82c0b4e5

rilysh avatar Feb 12 '24 18:02 rilysh

Hmm interesting...? How build can be failed with just inlining? Edit: Just noticed it seems a test is also failing (but the fail unrelated to inlining)

rilysh avatar Feb 12 '24 18:02 rilysh

This is my fault not yours

bapt avatar Feb 12 '24 18:02 bapt