freebsd-src icon indicating copy to clipboard operation
freebsd-src copied to clipboard

Published 20 hours ago • verified publisher icon freebsd

sys: rename preprocessed assembly-language files to .S

Open ehem opened this issue 2 years ago • 1 comments

Even though assembly-language .s files aren't supposed to be run through cpp, clearly all of these are being preprocessed (#include is a strong indicator). A few potentially non-preprocessed files remain named .s.

Differential Revision: https://reviews.freebsd.org/D35908

ehem avatar Jul 26 '22 22:07 ehem

Simply rebased since the main branch got pushed. Clearly all the checks passed though.

ehem avatar Jul 26 '22 23:07 ehem

Committed to main in ccd9b49f20e7a2e6eac1e7e68db23e222bf40263

emaste avatar Nov 02 '22 14:11 emaste

Only one of the commits for this pull request was pushed, reopening because I want to land some.

bsdimp avatar Nov 02 '22 15:11 bsdimp

This pull request was for the .s to .S rename; other changes should be in other pull requests? Anyhow no harm in grabbing other commits from here as you review/approve.

emaste avatar Nov 02 '22 15:11 emaste

Yea, they should be, but the overhead for the two I just landed in asking for them to be so was too large for me :)

bsdimp avatar Nov 02 '22 17:11 bsdimp

I've committed the last of the original changes from this that are no-brainers to commit. What's the status of the rest of them? They appear to be in review, under active development, etc. That generally suggests that we close the PR unless there's a reason to keep it open...

bsdimp avatar Feb 05 '23 17:02 bsdimp

Closing this pull request... It's expanded somewhat beyond it's original remit... All changes that don't need discussion and/or additional work have landed.

bsdimp avatar Feb 05 '23 22:02 bsdimp