freebsd-src icon indicating copy to clipboard operation
freebsd-src copied to clipboard

Use C++ features and headers in C++ code instead of C

Open AZero13 opened this issue 3 years ago • 1 comments

We don’t need to use integers as booleans or the C standard headers when we have the C++ standard headers and booleans

AZero13 avatar Jul 31 '21 21:07 AZero13

lib/csu/tests/cxx_constructors.cc:56 1 substituted for false?

supahero1 avatar Jan 17 '22 16:01 supahero1

Too many changes in this to effectively review. Please split it up into logical changes.

bsdimp avatar Nov 14 '22 17:11 bsdimp

This pull request is too wide-ranging. The changes are likely be good, but it's impossible to land as is. Please create a new pull request per directory as there are different reviewers needed for different parts of the tree. Some of the changes add std:: (which is likely right, but not mentioned) and noexcept (which may or may not be right, I didn't study the code to know). at the very least, this information should be reflected i the commit messages. Thanks.

bsdimp avatar Feb 04 '23 18:02 bsdimp