freebsd-src icon indicating copy to clipboard operation
freebsd-src copied to clipboard

feat: Tune if_em Adaptive Interrupt Moderation

Open rkarahan80 opened this issue 6 months ago • 2 comments

Introduces an intermediate latency state (itr_latency_medium) to the Adaptive Interrupt Moderation (AIM) logic in the if_em (Intel PRO/1000) network driver.

This change aims to provide a smoother transition between low-latency and high-throughput interrupt moderation settings, potentially improving the balance of network responsiveness and CPU utilization under varied traffic loads.

The specific heuristic changes include:

  • Added EM_INTS_10K for the new medium state.
  • Modified the state machine in em_newitr() to transition to/from itr_latency_medium based on packet and byte count thresholds.

Further testing and empirical tuning of the new thresholds will be necessary to fully validate the performance impact. Signed-off-by: Recep Karahan [email protected]

rkarahan80 avatar Jun 27 '25 06:06 rkarahan80

Thank you for taking the time to contribute to FreeBSD! There are a few issues that need to be fixed:

  • Missing Signed-off-by lines6567663a5235055f046a0256858dce88f38e3193
  • Real email address is needed6567663a5235055f046a0256858dce88f38e3193

github-actions[bot] avatar Jun 27 '25 06:06 github-actions[bot]

Please don't spam our repository with AI-generated slop. It serves only to waste our time and yours. After reviewing some of your PRs, I have concluded that the rest do not warrant even a cursory review. Therefore I will close them all. If you wish to contribute again in the future, you must take more care with your submissions. You must build and test them all, at least! And you need to consider what the PR does. Is it even useful? Furthermore, the copyright status of AI-generated code is currently unclear, so the project is not accepting any such submissions at this time. But AI can of course be used as an aid, such as for debugging. Finally, I encourage you to read these documents to familiarize yourself with our project and its practices.

https://docs.freebsd.org/en/books/developers-handbook/ https://docs.freebsd.org/en/articles/problem-reports/

asomers avatar Jun 29 '25 15:06 asomers