freebsd-src icon indicating copy to clipboard operation
freebsd-src copied to clipboard

fsck_msdosfs: reduce the scope of dentry deletion when dirent flags is ATTR_VOLUME

Open anmuxixixi opened this issue 7 months ago • 4 comments

fsck_msdosfs: reduce the scope of dentry deletion when dirent flags is ATTR_VOLUME

When dentry flag is ATTR_VOLUME because of 1 bit flip(from 0x10 to 0x18), removede function will delete all dentry from invalid dentry postion, so some normal dentries will be deleted in the same cluster.Unfortunately, these normal directories and files will not be visible to the user after wo do fsck_msdos

anmuxixixi avatar May 07 '25 15:05 anmuxixixi

Thank you for taking the time to contribute to FreeBSD! There are a few issues that need to be fixed:

  • Missing Signed-off-by lines661ebed16f52dab7cddd69eafa6bc5d770e66801
  • Real email address is needed661ebed16f52dab7cddd69eafa6bc5d770e66801

github-actions[bot] avatar May 07 '25 15:05 github-actions[bot]

@OlCe2 can you take a look at this in light of your review of the ExFAT stuff maybe? if you have time...

bsdimp avatar Jul 25 '25 17:07 bsdimp

@OlCe2 can you take a look at this in light of your review of the ExFAT stuff maybe? if you have time...

Sorry, missed that. On discovering the title, I thought exactly the same as you... :-)

OlCe2 avatar Sep 05 '25 16:09 OlCe2

@OlCe2 can you take a look at this in light of your review of the ExFAT stuff maybe? if you have time...

@bsdimp Sorry for the delayed reply.

The fsck_msdosd is a tool designed to repair corrupted vfat/fat/msdos filesystem, not exfat filesystem. This FreeBSD-derived tool is currently imported into the Android external/fsck_msdos repository.]

We recently identified a bug in this tool and are reaching out to request a fix.Thanks.

anmuxixixi avatar Dec 16 '25 08:12 anmuxixixi