freebsd-src icon indicating copy to clipboard operation
freebsd-src copied to clipboard
verified publisher icon freebsd

rc.d/zpool: change mountcritlocal dep from BEFORE to REQUIRE

Open svmhdvn opened this issue 9 months ago • 3 comments

In cases where the /boot directory is mounted from a different disk through /etc/fstab, /boot/zfs/zpool.cache will not be found during a rc.d/zpool run. This is because /etc/fstab mounts are mounted in rc.d/mountcritlocal, which currently runs AFTER (i.e. REQUIRE:) rc.d/zpool.

This change swaps the rcorder of rc.d/zpool's dependency on mountcritlocal from BEFORE: to REQUIRE:. This will ensure that /boot (or even /etc/ in some configurations) to be visible while searching for zpool.cache.

svmhdvn avatar Mar 14 '25 15:03 svmhdvn

Automated message from ghpr: Thank you for your submission. This PR has been merged to FreeBSD's branch. These changes will appear shortly on our GitHub mirror.

bsdimp avatar Jun 13 '25 15:06 bsdimp

This causes systems with ZFS legacy filesystems, those specified in /etc/fstab to fail to enter multi-user because mountcritlocal cannot find fstyp zfs.

cschuber avatar Jun 14 '25 06:06 cschuber

Thank you for taking the time to contribute to FreeBSD! There is an issue that needs to be fixed:

  • Missing Signed-off-by linesda3840446684b69d1fdf15f3159a75d6138bd6d9

github-actions[bot] avatar Jun 14 '25 06:06 github-actions[bot]

This was fixed by cy@ in head after the initial commit.

bsdimp avatar Aug 04 '25 19:08 bsdimp