freebsd
Update jemalloc to version 5.3.0
Move to Github PR by @bsdimp 's request through freebsd-current mailiing list.
jemalloc 5.3.0 was released in 2022 but has not been imported into FreeBSD base system yet. The new version of jemalloc includes new features and bug fixes which are listed on release note.
We'll need an exp run and this needs to be redone as a vendor branch update (which I'm on the hook for).....
@bsdimp I don't have src commit bit which is required for vendor import. Can you import jemalloc 5.3.0 in vendor/jemalloc for me please? I will take the rest of work (merging, editing Makefile...)
I'll import the 5.3.0 into vendor/jemalloc, but it appears that doesn't exist yet, so I'll need to look closely at what needs to happen to make it happen. Looks like it's never really been imported via the svn vendor tree. I need to go study this more closely to know the right thing to import. Sorry this is taking so long
Yeah sorry that I was also occupied by other things. I got some issues when testing this on arm64 (not related to jemalloc but arm64 itself). I'll work on test this in amd64 and arm64.
Reflected upstream changes by rebasing main. 5.3.0 vendor import is required.
Thanks for the rebase. How'd you generate things? I have a rather large diff to your stuff in the sanity check diff I did. And how'd you work around the _pthread_getname_np issue? I think it's a namespace issue. I have lots of questions... I'm also having a build issue with _pthread_getaffinity_np, but I think that's because autogen / ./configure didn't set JEMALLOC_HAVE_SECURE_GETENV, JEMALLOC_HAVE_PTHREAD_SETNAME_NP, JEMALLOC_HAVE_SCHED_GETCPU or JEMALLOC_HAVE_SCHED_SETAFFINITY. Were those enabled by hand or ???
So far I've done this by checking out the 5.3.0 tag in a git tree, copying all the files over to my vendor import tree, then running
% autogen
% ./configure --enable-autoconf --with-version=5.3.0-0-g54eaed1d8b56b1aa528be3bdd1877e59c56fa90c --with-xslroot=/usr/local/share/xsl/docbook
% gmake build_doc
and copying everything over.
But, it looks like the various .sh -> .h scripts didn't get run quite right.
I'm seeing issues with the fact that pthread_np.h is included inside a 'namespace.h' block, but we unnamespace before we build jemalloc.c (still looking into how we do that).
I do see that setting JEMALLOC_HAVE_SCHED_* defines in my tree lets it compile.
So understanding how you got here is going to be critical if we ever want to update it again in the future.
@bsdimp I used FREEBSD-upgrade script under contrib/jemalloc. I'll try the merge again and see if there is any problem.
@bsdimp I used
FREEBSD-upgradescript undercontrib/jemalloc. I'll try the merge again and see if there is any problem.
Where did you get the tree you used for the upstream part of that? Oh, I didn't see you'd updated it... I need to study it a bit... But it does look like it will answer many of my questions I think... There's stuff I still don't quite understand, but I'd like to get to the bottom of it all so that I can get the right stuff into the 'update the vendor branch' stuff since that's typically how we've updated things since the migration to git. It's also providing a much higher level of confidence for me that there's nothing rogue in this update (not that I suspect you personally, but after xz I have to make sure that my trust isn't misplaced since a tiny number of people spoil the fun for everyone else).
And how'd you work around the _pthread_getname_np issue? I think it's a namespace issue.
https://reviews.freebsd.org/D41461 might be related to this issue.
OK. So like, I'm lame and tardy. But I think I've mopped up all the issues. #1811 is an update to this.