freebsd-src icon indicating copy to clipboard operation
freebsd-src copied to clipboard

rman updates/cleanup

Open ehem opened this issue 1 year ago • 3 comments

Upon examination it turned out rman_reserve_resource_bound() was completely unused. This is distinctly troublesome since it serves to misdirect people who were instead looking for RF_ALIGNMENT_LOG2(). As such nuke rman_reserve_resource_bound() and fold everything back into rman_reserve_resource().

Also spot rman_make_alignment_flags() was rather out date and really needed an update.

ehem avatar May 09 '24 21:05 ehem

Take care of the one style issue the checker legitimately flagged. The others are due to this being legacy and I wasn't aiming to do full update.

I'm still eyeing rman_make_alignment_flags() and thinking it should be inline instead.

ehem avatar May 09 '24 21:05 ehem

Actually, the other issue is: Should DPRINTF() be in non-debug kernels? Seems it is mostly well-tested at this point.

ehem avatar May 09 '24 21:05 ehem

Rebased onto main. Adjust to leave 2 more words in the man page behind. I was thinking I was going to propose an adjustment which needed the resource manager functions marked constant. Yet upon further checking seems this is unnecessary, though worthwhile.

ehem avatar May 10 '24 22:05 ehem